Conversation
This was referenced Mar 19, 2025
perf(allocator/vec2): replace
self.reserve(1) calls with self.grow_one() for better efficiency
#9856
Merged
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #9881 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Dunqing
changed the base branch from
03-13-feat_allocator_vec2_align_the_retain_method_with_the_standard_implementation
to
graphite-base/9881
Dunqing
force-pushed
the
03-19-feat_allocator_vec2_implement_extend_desugared_method_as_extend_internal_implemention
branch
from
711ad2e to
834e350
Compare
Dunqing
force-pushed
the
graphite-base/9881
branch
from
edee838 to
e637e2e
Compare
Dunqing
force-pushed
the
03-19-feat_allocator_vec2_implement_extend_desugared_method_as_extend_internal_implemention
branch
10 times, most recently
from
32dd4d6 to
063f74f
Compare
Dunqing
force-pushed
the
03-19-feat_allocator_vec2_implement_extend_desugared_method_as_extend_internal_implemention
branch
12 times, most recently
from
a1f3cb7 to
bf153f2
Compare
Dunqing
commented
Mar 21, 2025
Comment on lines
+2299
to
+2317
| let (lower, _) = iterator.size_hint(); | ||
| self.reserve(lower.saturating_add(1)); |
Member
Author
There was a problem hiding this comment.
After a hundred experiments, I concluded that this has an impact on performance.
This was referenced Apr 15, 2025
This was referenced Apr 25, 2025
Member
Author
|
This is a testing PR, the real work has been done in #10670. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.